8000 Fix newline of map type by itchyny · Pull Request #29 · k0kubun/pp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix newline of map type #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2019
Merged

Fix newline of map type #29

merged 2 commits into from
Mar 3, 2019

Conversation

itchyny
Copy link
Contributor
@itchyny itchyny commented Mar 3, 2019

The bug is introduced in #25, I'm not sure why the weird behavior is not found for years.

Before After
screen shot 2019-03-03 at 23 30 52 screen shot 2019-03-03 at 23 31 18

@k0kubun
Copy link
Owner
k0kubun commented Mar 3, 2019

Oh wow, thanks to catch this. LGTM.

@k0kubun k0kubun merged commit b13c7f2 into k0kubun:master Mar 3, 2019
@itchyny itchyny deleted the fix-map-newline branch March 3, 2019 15:27
k0kubun added a commit that referenced this pull request Nov 11, 2020
ref: #29

This test is worthwhile, but it needs to be fixed for CI stability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0