8000 Support credentials distribution by eromanova · Pull Request #712 · k0rdent/kcm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support credentials distribution #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2024
Merged

Support credentials distribution #712

merged 2 commits into from
Dec 6, 2024

Conversation

eromanova
Copy link
Collaborator

This PR includes the following changes:

  1. Rename TemplateManagement -> AccessManagement
  2. AccessManagement spec is extended to receive the list of credential names to be distributed to target namespaces
  3. Access management controller now supports credentials distribution

Closes #692

@eromanova eromanova self-assigned this Dec 4, 2024
@eromanova eromanova force-pushed the credentials-distribution branch from 9541d30 to 59c82bb Compare December 4, 2024 12:39
@eromanova eromanova requested a review from zerospiel December 5, 2024 12:37
zerospiel
zerospiel previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator
@zerospiel zerospiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple optional nit comments, in general LGTM, approved

@eromanova eromanova force-pushed the credentials-distribution branch from 59c82bb to d270c60 Compare December 6, 2024 08:37
@Kshatrix Kshatrix merged commit b35b0da into k0rdent:main Dec 6, 2024
5 checks passed
@Schnitzel Schnitzel mentioned this pull request Dec 6, 2024
Closed
@eromanova eromanova deleted the credentials-distribution branch December 27, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kshatrix Kshatrix Kshatrix approved these changes

@zerospiel zerospiel zerospiel left review comments

@a13x5 a13x5 Awaiting requested review from a13x5 a13x5 is a code owner

Assignees

@eromanova eromanova

Labels
None yet
Projects
k0rdent
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Credentials Distribution System
3 participants
@eromanova @zerospiel @Kshatrix
0