10000 Fix schema.json for generating JSON Schema of schema.json by k1LoW · Pull Request #646 · k1LoW/tbls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix schema.json for generating JSON Schema of schema.json #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 26, 2025
Merged

Conversation

k1LoW
Copy link
Owner
@k1LoW k1LoW commented Jan 23, 2025

And improve implementation to output JSON Schema correctly.

@k1LoW k1LoW self-assigned this Jan 23, 2025

This comment has been minimized.

@k1LoW k1LoW added the minor label Jan 23, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment 8000 has been minimized.

@k1LoW k1LoW changed the title Generate JSON Schema for schema.json Fix schema.json for generating JSON Schema of schema.json Jan 24, 2025
@k1LoW k1LoW marked this pull request as ready for review January 25, 2025 07:16

This comment has been minimized.

Copy link
Contributor

Code Metrics Report

main (3e49fa7) #646 (08bc65f) +/-
Coverage 55.8% 54.3% -1.5%
Code to Test Ratio 1:0.4 1:0.4 +0.0
Test Execution Time 3m31s 4m34s +1m3s
Details
  |                     | main (3e49fa7) | #646 (08bc65f) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          55.8% |          54.3% | -1.5% |
  |   Files             |             52 |             52 |     0 |
  |   Lines             |           4775 |           4771 |    -4 |
- |   Covered           |           2666 |           2595 |   -71 |
+ | Code to Test Ratio  |          1:0.4 |          1:0.4 |  +0.0 |
  |   Code              |          10358 |          10341 |   -17 |
  |   Test              |           4342 |           4342 |     0 |
- | Test Execution Time |          3m31s |          4m34s | +1m3s |

Code coverage of files in pull request scope (42.5% → 43.8%)

Files Coverage +/-
schema/cardinality.go 100.0% 0.0%
schema/json.go 85.3% +0.6%
schema/schema.go 39.8% 0.0%
schema/yaml.go 0.0% 0.0%

Reported by octocov

@k1LoW k1LoW merged commit 576d46c into main Jan 26, 202 8529 5
4 checks passed
@k1LoW k1LoW deleted the jsonschema branch January 26, 2025 01:40
@github-actions github-actions bot mentioned this pull request Jan 25, 2025
@k1LoW k1LoW mentioned this pull request Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0