fix: use len() for relation check in detectShowColumnsForER to support include filter #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Metrics Report
Details | | main (a730b8f) | #699 (b7df563) | +/- |
|---------------------|----------------|----------------|-------|
- | Coverage | 55.7% | 54.1% | -1.6% |
| Files | 52 | 52 | 0 |
| Lines | 4813 | 4813 | 0 |
- | Covered | 2683 | 2606 | -77 |
| Code to Test Ratio | 1:0.4 | 1:0.4 | 0.0 |
| Code | 10419 | 10419 | 0 |
| Test | 4358 | 4358 | 0 |
+ | Test Execution Time | 4m40s | 4m33s | -7s |Code coverage of files in pull request scope (64.1% → 64.1%)
Reported by octocov |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #685
When using the
includeoption in .tbls.yml to filter tables, the er.showColumnTypes.related/primary setting did not work as expected: columns other than PK and FK were not hidden in the ER diagram output. This is because the previous implementation checked only for nil on ChildRelations and ParentRelations, but after filtering, these fields become empty slices ([]) rather thannil.By changing the check to use len(cc.ChildRelations) > 0 || len(cc.ParentRelations) > 0, the logic now correctly detects related columns even when the include filter is used. This ensures that only PK and FK columns are shown in the ER diagram as intended, regardless of the use of include.