8000 Cross schema foreign keys cannot be procesed by ypyl · Pull Request #383 · k1LoW/tbls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cross schema foreign keys cannot be procesed #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 8, 2022

Conversation

ypyl
Copy link
Contributor
@ypyl ypyl commented Nov 7, 2022

Issue

Not able to run the full set of tests within dev container (e.g. it is not clear how to run dynamodb related tests, also there are some fails with test_ext_subcommand from makefile and I really can't understand what it is doing and why it is required.

I will be happy to fix any issues and follow ups from you.
Thank you once again for the great utility.

@ypyl ypyl marked this pull request as ready for review November 7, 2022 21:36
@@ -0,0 +1,32 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file needs to be committed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 10e897e

@k1LoW
Copy link
Owner
k1LoW commented Nov 8, 2022

@ypyl Thank you for your contribution!!!

Copy link
Owner
@k1LoW k1LoW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

@k1LoW k1LoW merged commit d153f76 into k1LoW:main Nov 8, 2022
@github-actions github-actions bot mentioned this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0