Only create k3s-images.txt on amd64 #2273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list is the same across architectures, and is validated against the list in git as part of CI... so there's no reason to be pushing it from every pipeline. It's also causing conflicts when multiple pipelines try to upload it at the same time. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Sep 17, 2020
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Sep 17, 2020
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Sep 17, 2020
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
This was referenced Sep 17, 2020
MonzElmasry
approved these changes
Sep 18, 2020
brandond
added a commit
that referenced
this pull request
Sep 18, 2020
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
that referenced
this pull request
Sep 18, 2020
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
that referenced
this pull request
Sep 18, 2020
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Only create k3s-images.txt on amd64
Types of Changes
Verification
Linked Issues
#2271
Further Comments
The list is the same across architectures, and is validated against the
list in git as part of CI... so there's no reason to be pushing it from
every pipeline. It's also causing conflicts when multiple pipelines try
to upload it at the same time.