8000 Upgrading k8s to 1.11.2 by johnugeorge · Pull Request #942 · kubeflow/trainer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrading k8s to 1.11.2 #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2019
Merged

Upgrading k8s to 1.11.2 #942

merged 1 commit into from
Feb 13, 2019

Conversation

johnugeorge
Copy link
Member
@johnugeorge johnugeorge commented Feb 11, 2019 •
edited
Loading

This contains

  1. Gopkg.toml and vendor/ to reflect k8s packages upgrade
  2. pkg/client, zz_generated.deepcopy.go are regenerated by running hack/update_codegen.sh script
  3. other pkg changes to match newer apis of k8s 1.11.2

This change is Reviewable

@johnugeorge
Copy link
Member Author

/retest

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 67.962% when pulling aa1ee5b on johnugeorge:0.11-upgrade into 855ee21 on kubeflow:master.

@johnugeorge
Copy link
Member Author

/retest

1 similar comment
@johnugeorge
Copy link
Member Author

/retest

@johnugeorge johnugeorge changed the title WIP: Upgrading k8s to 1.11.2 Upgrading k8s to 1.11.2 Feb 12, 2019
@johnugeorge
Copy link
Member Author

/assign @richardsliu
/assign @gaocegege
/hold

gaocegege
gaocegege approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member
@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

While I'd appreciate it if you could split the commit. It is hard to know which changes are done manually.

@johnugeorge
Copy link
Member Author

@gaocegege edited the comment #942 (comment) to describe the changes. Since all the changes go together, it is difficult to split. Point 3 is the manual change in the PR.

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit c284947 into kubeflow:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

@codeflitting codeflitting Awaiting requested review from codeflitting

@jimexist jimexist Awaiting requested review from jimexist

Assignees

@gaocegege gaocegege

@richardsliu richardsliu

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@johnugeorge @coveralls @richardsliu @k8s-ci-robot @gaocegege
0