Apply resources appropriately to both launcher and node containers #2653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 15338735909Details
💛 - Coveralls |
c80c3ff to
c0d40e8
Compare
The Trainer method has been updated to apply resources appropriately to both the launcher and node containers based on this flag. Key changes include: - Added the `isRunLauncherAsNode` method to determine if the launcher should be run as a node. - Updated the Trainer method to conditionally apply resource configurations to the launcher container based on the `runLauncherAsNode` value. - Enhanced test cases to cover scenarios for resource application to both launcher and node pods based on the MPI policy settings. Signed-off-by: Krishnaswamy Subramanian <subramk@thoughtworks.com>
c0d40e8 to
6925f41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Trainer method has been updated to apply resources appropriately to both the launcher and node containers based on this fl 8000 ag.
Key changes include:
isRunLauncherAsNodemethod to determine if the launcher should be run as a node.runLauncherAsNodevalue.Which issue(s) this PR fixes: Fixes #2650