-
Notifications
You must be signed in to change notification settings - Fork 783
Add Changelog for Trainer v2.0.0-rc.0 #2666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Changelog for Trainer v2.0.0-rc.0 #2666
Conversation
Pull Request Test Coverage Report for Build 15565302403Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you!
/lgtm
/approve
/hold
for @kubeflow/wg-training-leads @astefanutti @Electronic-Waste
/cherry-pick release-2.0 |
@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-2.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kramaranya Thanks for this! Basically LGTM.
950d5ef
to
2bb7216
Compare
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: kramaranya <kramaranya15@gmail.com>
2bb7216
to
8096123
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kramaranya Thanks for this great work!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Electronic-Waste, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel We trainer leads will be busy in the next week for KubeCon. |
@tenzen-y: new pull request created: #2667 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Added Changelog for Trainer
v2.0.0-rc.0
.Thanks everyone for your contribution!
I grouped it by:
Let me please know if anything should be chnaged