-
Notifications
You must be signed in to change notification settings - Fork 783
KEP-2628: Support KAI Scheduler in Kubeflow Trainer #2663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Harshal292004 <malaniharshal95@gmail.com>
@Harshal292004: GitHub didn't allow me to request PR reviews from the following users: romanbaron, kannon92. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 15519341253Details
💛 - Coveralls |
Signed-off-by: Harshal292004 <malaniharshal95@gmail.com>
@@ -0,0 +1,89 @@ | |||
# KEP-2628: Support KAI Scheduler in Kubeflow Trainer | |||
|
|||
This KEP proposes integrating NVIDIA's KAI Scheduler into Kubeflow Trainer V2 to enable gang-scheduling capabilities for TrainJob resources, extending the existing PodGroupPolicy API to support KAI alongside current schedulers like Co-Scheduling. The integration will leverage KAI's PodGrouper service to create scheduling queues and apply appropriate labels for efficient resource allocation in AI workloads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment here: PodGrouper Service will create the podGroup object, queues will have to be created by a different entity, probably by a trainer plugin.
This point is perfectly explained below so the rest is accurate.
} | ||
|
||
type KAIConfig struct { | ||
Queue string `json:"queue,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be really confusing to someone who uses KAI + Kueue.
cc @romanbaron.
Is there anyway to use gang scheduling in KAI without needing a KAI queue?
Volcano is used for PodGroup functionality in Trainer but I don't think one has to use Volcano Queues to use this.
This is the Kubeflow Enhancement Proposal for supporting KAI Scheduler in Kubeflow Trainer V2:
Related: #2628
Any suggestions or feedback are welcome !
@romanbaron @kannon92
/cc @andreyvelich @tenzen-y @Electronic-Waste