8000 Initiate a Shared Library by rschlaefli · Pull Request #2 · kwizapp/kwiz-utils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Initiate a Shared Library #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 20, 2020
Merged

Initiate a Shared Library #2

merged 14 commits into from
Mar 20, 2020

Conversation

rschlaefli
Copy link
Contributor
@rschlaefli rschlaefli commented Mar 19, 2020 •
edited
Loading

Description

This PR sets up an initial version of a shared NPM package/library.
The library code gets built and pushed to our Github Package Registry, from which we can then install it using NPM.

Related Issues

Closes #1

Checklist

  • Have you added tests where necessary? Do all the test pass?
  • Have you added descriptive comments to your code?
  • Have you updated the documentation related to this propo

@rschlaefli rschlaefli self-assigned this Mar 19, 2020
@rschlaefli rschlaefli added this to the Sprint 1 milestone Mar 19, 2020
@rschlaefli rschlaefli linked an issue Mar 19, 2020 that may be closed by this pull request
Extract shared code to a separate library #1
Closed
nikzaugg
nikzaugg reviewed Mar 20, 2020
View reviewed changes
Copy link
Contributor
@nikzaugg nikzaugg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

Just one question: I see that we run test in the workflow, but only on release, right?. Shouldn't we make them run with every change?

@rschlaefli
Copy link
Contributor Author
rschlaefli commented Mar 20, 2020 •
edited
Loading

@nikzaugg yep, totally missed that! thanks for the review!

@rschlaefli rschlaefli closed this Mar 20, 2020
@rschlaefli rschlaefli reopened this Mar 20, 2020
@rschlaefli
Copy link
Contributor Author

Looks good. Thanks.

Just one question: I see that we run test in the workflow, but only on release, right?. Shouldn't we make them run with every change?

@nikzaugg Adapted the code to test on every push, but publish only on release/created events

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nikzaugg nikzaugg self-requested a review March 20, 2020 12:37
nikzaugg
nikzaugg approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor
@nikzaugg nikzaugg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@rschlaefli rschlaefli merged commit 4ecf09c into dev Mar 20, 2020
@rschlaefli rschlaefli deleted the SetupNPMPackage branch March 20, 2020 12:48
nikzaugg added a commit that referenced this pull request May 19, 2020
@nikzaugg @rschlaefli
Release v1.0.1 (#53)
526a62b 
* Initiate a Shared Library (#2)

* Initialize new typescript lib

* Migrate code and tests for validate and util

* Add an initial workflow for NPM package publishing

* Perform husky upgrade

* add some commands to README

* Try build on push

* Fix: Failing tests due to coverage

* Update package name

* Add installation instructions

* Only publish on release (we can also publish from CLI)

* Test on all push events but only deploy a new release on the release-created event

* Fix: Ensure that the testing step also uses the Github Package Registry

* Use Github Package Registry only for the kwizapp scope

* Add NODE_AUTH_TOKEN

* 📦 Bump package versions to v1.0.0 (#54)

* ⬆️ Bump package to v1.0.1 (#55)

Co-authored-by: Roland Schläfli <rolandschlaefli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikzaugg nikzaugg nikzaugg approved these changes

@alexscheitlin alexscheitlin Awaiting requested review from alexscheitlin

Assignees

@rschlaefli rschlaefli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract shared code to a separate library
2 participants
@rschlaefli @nikzaugg
0