8000 feat: Force delete by akucharska · Pull Request #3716 · kyma-project/busola · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Force delete #3716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Mar 3, 2025
Merged

feat: Force delete #3716

merged 18 commits into from
Mar 3, 2025

Conversation

akucharska
Copy link
Contributor
@akucharska akucharska commented Feb 18, 2025 •
edited by mrCherry97
Loading

Description

Changes proposed in this pull request:

  • Add the possibility to force delete modules with all associated resources

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 18, 2025
@akucharska akucharska linked an issue Feb 18, 2025 that may be closed by this pull request
Force delete kyma module #2613
Closed
4 tasks
@mrCherry97 mrCherry97 self-assigned this Feb 20, 2025
mrCherry97
mrCherry97 requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor
@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add some HintButton or MessageStrip with info to help users understand the consequences, that Busola will remove all of the connected resources, and then remove the module. Contact @grego952 for proper message which will be the best to display.

@grego952 grego952 self-assigned this Feb 26, 2025
mrCherry97
mrCherry97 requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor
@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to take a deeper look, so partial review.

@akucharska @mrCherry97
Update src/shared/hooks/useDeleteResource.js
8579370 
Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>
mrCherry97
mrCherry97 previously approved these changes Feb 27, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 27, 2025
grego952
grego952 reviewed Feb 27, 2025
View reviewed changes
@akucharska @grego952
Update public/i18n/en.yaml
46ad3e3 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Feb 27, 2025
@akucharska akucharska enabled auto-merge (squash) February 27, 2025 14:27
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 3, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 3, 2025
@akucharska akucharska merged commit f5b8f83 into kyma-project:main Mar 3, 2025
19 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 3, 2025
@mrCherry97 mrCherry97 deleted the force-delete branch March 3, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@grego952 grego952 grego952 approved these changes

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@mrCherry97 mrCherry97

@grego952 grego952

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Force delete kyma module
4 participants
@akucharska @mrCherry97 @grego952 @kyma-bot
0