8000 feat: Enable AI assistant only for SAP users by mrCherry97 · Pull Request #3727 · kyma-project/busola · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Enable AI assistant only for SAP users #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 3, 2025
Merged

feat: Enable AI assistant only for SAP users #3727

merged 5 commits into from
Mar 3, 2025

Conversation

mrCherry97
Copy link
Contributor
@mrCherry97 mrCherry97 commented Feb 24, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • add useCheckSAPUser hook
  • adjust jsonata fn

Related issue(s)
Closes #3714

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@mrCherry97 mrCherry97 marked this pull request as ready for review February 24, 2025 12:59
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2025
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 24, 2025
@mrCherry97
Copy link
Contributor Author

To test it:

  1. download the kubeconfig from SKR
  2. adjust PORT in vite.config.mjs to 8000
  3. enable KYMA_CONMPANION in the config (dev/stage depends on which SKR you used)
  4. run app with dev/stage config (depends on which SKR you used)
  5. Connect the cluster and check if AI is available
  6. Generate a token for ServiceAccount or connect local k3d cluster
  7. Connect to the Busola
  8. Check if AI is available

@mrCherry97 mrCherry97 enabled auto-merge (squash) February 24, 2025 13:41
@KonradPietocha
Copy link
Contributor
KonradPietocha commented Feb 26, 2025 •
edited
Loading

I don't know if it's a bug but I connect to kubeconfig where AI button is available then open Joule, keep it open but connect to another where Joule button is not available and not allowed. Joule is still open:

Zrzut ekranu 2025-02-26 o 14 02 02

Zrzut ekranu 2025-02-26 o 14 02 52

KonradPietocha
KonradPietocha previously approved these changes Feb 27, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 27, 2025
@KonradPietocha KonradPietocha self-requested a review February 27, 2025 12:52
@KonradPietocha
Copy link
Contributor

There is still some problem with closing this chat. Sometimes it works and sometimes it doesn't

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Feb 27, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 27, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 3, 2025
@kyma-bot
Copy link
Contributor
kyma-bot commented Mar 3, 2025

New changes are detected. LGTM label has been removed.

@mrCherry97 mrCherry97 added the lgtm Looks good to me! label Mar 3, 2025
@mrCherry97 mrCherry97 merged commit 207f19d into kyma-project:main Mar 3, 2025
19 checks passed
@mrCherry97 mrCherry97 deleted the ai-sap-users branch March 3, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonradPietocha KonradPietocha KonradPietocha approved these changes

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@KonradPietocha KonradPietocha

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AI assistant should be available only for @sap.com users
4 participants
@mrCherry97 @KonradPietocha @kyma-bot @OliwiaGowor
0