8000 chore: Bump openapi-schema-to-json-schema package by OliwiaGowor · Pull Request #3900 · kyma-project/busola · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Bump openapi-schema-to-json-schema package #3900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

chore: Bump openapi-schema-to-json-schema package #3900

merged 1 commit into from
May 5, 2025

Conversation

OliwiaGowor
Copy link
Contributor
@OliwiaGowor OliwiaGowor commented Apr 30, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • Bumped openapi-schema-to-json-schema package to 5.1.0
  • Fixed accesibleName error
    Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@OliwiaGowor OliwiaGowor mentioned this pull request Apr 29, 2025
Open
45 tasks
@OliwiaGowor OliwiaGowor marked this pull request as ready for review April 30, 2025 10:25
mrCherry97
mrCherry97 requested changes Apr 30, 2025
View reviewed changes
src/shared/components/UI5RadialChart/UI5RadialChart.js
@@ -24,7 +24,7 @@ export const UI5RadialChart = ({
return (
<div className={classnames} >
<RadialChart
accessibleName={'Radial chart'}
aria-label={'Radial chart'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change necessary? We added that because of accessibility validation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's throwing errors because there is no property accessibleName for the RadialChart
image

@mrCherry97 mrCherry97 self-assigned this Apr 30, 2025
@mrCherry97 mrCherry97 enabled auto-merge (squash) May 5, 2025 07:03
@mrCherry97 mrCherry97 merged commit e137adf into kyma-project:main May 5, 2025
101 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@KonradPietocha KonradPietocha Awaiting requested review from KonradPietocha KonradPietocha is a code owner

Assignees

@mrCherry97 mrCherry97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OliwiaGowor @mrCherry97
0