feat: Relax immutability requirements on match statements for generate rules #12784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rules Signed-off-by: Tomas Aschan <tomasl@spotify.com>
Signed-off-by: Tomas Aschan <tomasl@spotify.com>
e73dff0 to
db3f376
Compare
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12784 +/- ##
==========================================
+ Coverage 14.34% 14.36% +0.01%
==========================================
Files 926 926
Lines 102681 102698 +17
==========================================
+ Hits 14734 14752 +18
+ Misses 86225 86224 -1
Partials 1722 1722 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
realshuting
approved these changes
Apr 16, 2025
|
/cherry-pick release-1.14 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
…e rules (#12784) * feat: Allow changing match statements for non-synchronizing generate rules Signed-off-by: Tomas Aschan <tomasl@spotify.com> * fix: Address a couple of incorrect format string errors Signed-off-by: Tomas Aschan <tomasl@spotify.com> --------- Signed-off-by: Tomas Aschan <tomasl@spotify.com> Co-authored-by: shuting <shuting@nirmata.com>
eddycharly
pushed a commit
that referenced
this pull request
Apr 16, 2025
…e rules (#12784) (#12800) * feat: Allow changing match statements for non-synchronizing generate rules * fix: Address a couple of incorrect format string errors --------- Signed-off-by: Tomas Aschan <tomasl@spotify.com> Co-authored-by: Tomas Aschan <1550920+tomasaschan@users.noreply.github.com> Co-authored-by: shuting <shuting@nirmata.com>
Denish3436
pushed a commit
to Denish3436/kyverno
that referenced
this pull request
Apr 24, 2025
…e rules (kyverno#12784) * feat: Allow changing match statements for non-synchronizing generate rules Signed-off-by: Tomas Aschan <tomasl@spotify.com> * fix: Address a couple of incorrect format string errors Signed-off-by: Tomas Aschan <tomasl@spotify.com> --------- Signed-off-by: Tomas Aschan <tomasl@spotify.com> Co-authored-by: shuting <shuting@nirmata.com>
marevers
pushed a commit
to marevers/kyverno
that referenced
this pull request
May 5, 2025
…e rules (kyverno#12784) * feat: Allow changing match statements for non-synchronizing generate rules Signed-off-by: Tomas Aschan <tomasl@spotify.com> * fix: Address a couple of incorrect format string errors Signed-off-by: Tomas Aschan <tomasl@spotify.com> --------- Signed-off-by: Tomas Aschan <tomasl@spotify.com> Co-authored-by: shuting <shuting@nirmata.com> Signed-off-by: Martijn Evers <mevers@gk-software.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This updates the immutability validation for generate rules to allow updating the
matchstatements if and only if the policy before the change is not usingsynchronize: true.Updating
matchwas previously disallowed to avoid confusing or incorrect sync behavior when the set of trigger resources would change, but that is not a concern for non-synchronizing rules. This change relaxes the requirements slightly, by allowing updates tomatchstatements if no rule in the policy usessynchronize: true.It would, theoretically, be possible to relax this requirement even further, by matching rules before/after up by name, and applying this logic per rule rather than per policy, but doing so would require a larger refactor of the entire immutability checking code, as the current implementation works by resetting the values of all mutable fiels to a known value, hashing the resulting rule object, and then comparing the policy before and after the update by comparing the set of hashes; in other words, no such by-name match-up is done today. In the interest of leaving this change as small as possible, that is left out of scope.
Related issue
Fixes #12766
Milestone of this PR
Documentation (required for features)
My PR contains new or altered behavior to Kyverno.
What type of PR is this
Proposed Changes
Proof Manifests
Checklist
Further Comments