Add ability to set annotations on kyverno servicemonitors in helm chart #12797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off. |
Signed-off-by: Lawrence Webber <lawrence-webber@hotmail.co.uk>
Signed-off-by: Lawrence Webber <lawrence-webber@hotmail.co.uk>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12797 +/- ##
==========================================
- Coverage 14.35% 14.34% -0.01%
==========================================
Files 925 926 +1
Lines 102707 102681 -26
==========================================
- Hits 14745 14734 -11
+ Misses 86242 86225 -17
- Partials 1720 1722 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can you please add the changelog to |
|
I don't see a changelog? I've updated the README.md now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently there is no way to add annotations to the servicemonitor templates in the kyverno helm chart. This PR updates the chart to add this functionality
Related issue
#12795
Closes #12795Milestone of this PR
Documentation (required for features)
My PR contains new or altered behavior to Kyverno 8000 .
What type of PR is this
Proposed Changes
Proof Manifests
Checklist
Further Comments