8000 Fixed Helm Template for HPA by Nabsku · Pull Request #13009 · kyverno/kyverno · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed Helm Template for HPA #13009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Fixed Helm Template for HPA #13009

merged 1 commit into from
May 5, 2025

Conversation

Nabsku
Copy link
Contributor
@Nabsku Nabsku commented May 5, 2025

Explanation

A new option to deploy an HPA for the Admission Controller was introduced but the HPA configuration is not adhering to the actual HPA spec.

https://kubespec.dev/autoscaling/v2/HorizontalPodAutoscaler

What type of PR is this

/kind bug

Proposed Changes

This PR fixes the HPA template in accordance to the current v2 autoscaling api.

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.

@Nabsku Nabsku requested a review from eddycharly as a code owner May 5, 2025 12:28
@welcome Welcome
Copy link
welcome bot commented May 5, 2025
8000

Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 5, 2025
@Nabsku
Fixed Helm Template for HPA
5237d9c 
Signed-off-by: Yannick Wahner <thenabsku@gmail.com>
@Nabsku Nabsku force-pushed the fix/hpa-helm-config branch from 8959bfc to 5237d9c Compare May 5, 2025 12:29
realshuting
realshuting approved these changes May 5, 2025
View reviewed changes
Copy link
Member
@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @Nabsku !

@realshuting realshuting enabled auto-merge (squash) May 5, 2025 13:31
@codecov Codecov
Copy link
codecov bot commented May 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.23%. Comparing base (5b1f93d) to head (5237d9c).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13009      +/-   ##
==========================================
- Coverage   15.23%   15.23%   -0.01%     
==========================================
  Files         922      922              
  Lines      100305   100305              
==========================================
- Hits        15280    15279       -1     
- Misses      83295    83296       +1     
  Partials     1730     1730

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@realshuting
Copy link
Member

/cherry-pick release-1.14

@realshuting realshuting merged commit f99c120 into kyverno:main May 5, 2025
266 of 278 checks passed
@welcome Welcome
Copy link
welcome bot commented May 5, 2025

Congratulations! 🎉

Great job merging your first Pull Request here! How awesome! If you are new to this project, feel free to join our Slack community
200w

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 5, 2025
@Nabsku
Fixed Helm Template for HPA (#13009)
d8a53f9 
Signed-off-by: Yannick Wahner <thenabsku@gmail.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request May 5, 2025
Closed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 5, 2025
@Nabsku
Fixed Helm Template for HPA (#13009)
97e4cc4 
Signed-off-by: Yannick Wahner <thenabsku@gmail.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request May 5, 2025
Merged
@realshuting realshuting added cherry-pick-required cherry-pick-completed The PR was cherry-picked (or merged) to required release branches labels May 5, 2025
realshuting pushed a commit to realshuting/kyverno that referenced this pull request May 5, 2025
@Nabsku @realshuting
Fixed Helm Template for HPA (kyverno#13009)
30c4c6a 
Signed-off-by: Yannick Wahner <thenabsku@gmail.com>
Signed-off-by: ShutingZhao <shuting@nirmata.com>
realshuting pushed a commit that referenced this pull request May 5, 2025
@gcp-cherry-pick-bot @Nabsku
Fixed Helm Template for HPA (#13009) (#13014)
ccb3060 
Signed-off-by: Yannick Wahner <thenabsku@gmail.com>
Co-authored-by: Nabsku <thenabsku@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realshuting realshuting realshuting approved these changes

@eddycharly eddycharly Awaiting requested review from eddycharly eddycharly is a code owner

Assignees
No one assigned
Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required milestone 1.14.2 size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nabsku @realshuting
0