-
Notifications
You must be signed in to change notification settings - Fork 279
adding tekton policy to verify cosigned image #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: arunvel1988 <aryan.arunachalam@gmail.com>
Signed-off-by: arunvel1988 <aryan.arunachalam@gmail.com>
@joebowbeer can you review PR |
@joebowbeer @mcs @poblahblahblah @fernferret can you please review. And why is it taking time to review code ? |
@JimBugwadia kindly help review PR |
@JimBugwadia is this project archived? kindly help as PR is pending for more than a month... kindly help |
Only speaking for me, I have no idea why I got mentioned. I am not too experienced with Kyverno policies and for that won't review / approve PRs if I have no direct relation to them. And as far as I see this, I couldn't approve that change even if I wanted to, because I am not a "reviewer with write access". |
@realshuting can you review |
@mcs can you review ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a link to the issue this PR addresses.
Are we trying to verity a pod image signature or a TaskRun?
spec: | ||
containers: | ||
- name: signed-container | ||
image: index.docker.io/arunvel1988/signedimage:latest # Assumes this is a signed image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sample policies, please use the Kyverno test images:
- ghcr.io/kyverno/test-verify-image:signed (see https://kyverno.io/policies/other/verify-image/verify-image/)
Its best to avoid dependencies on other repositories and registries.
spec: | ||
containers: | ||
- name: unsigned-container | ||
image: index.docker.io/arunvel1988/unsignedimage:latest # This is an unsigned image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above.
any: | ||
- resources: | ||
kinds: | ||
- Pod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is simply verifying a Pod
and not verifying a TaskRun
. What is the intent?
- Pod | ||
verifyImages: | ||
- image: "index.docker.io/arunvel1988/*" | ||
key: "k8s://kyverno/cosign-key-secret" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the secret configured?
kinds: | ||
- Pod | ||
verifyImages: | ||
- image: "index.docker.io/arunvel1988/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above on images.
Related Issue(s)
Description
Checklist