8000 Version bump Kayrock by dantswain · Pull Request #377 · kafkaex/kafka_ex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Version bump Kayrock #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2019
Merged

Version bump Kayrock #377

merged 2 commits into from
Oct 13, 2019

Conversation

dantswain
Copy link
Collaborator

I added better error reporting to Kayrock on serialize errors. It should help diagnose the error you're seeing @joshuawscott

Example:

iex(1)> Kayrock.Request.serialize(%Kayrock.Fetch.V0.Request{})
** (Kayrock.InvalidRequestError) Error serializing request struct %Kayrock.Fetch.V0.Request{client_id: nil, correlation_id: nil, max_wait_time: nil, min_bytes: nil, replica_id: nil, topics: []}: %ArgumentError{message: "argument error"}
    :erlang.byte_size(nil)
    (kayrock) lib/generated/fetch.ex:49: Kayrock.Fetch.V0.Request.serialize/1
    (kayrock) lib/generated/fetch.ex:98: Kayrock.Request.Kayrock.Fetch.V0.Request.serialize/1

@dantswain
Update docker_up script
527204e 
Something changed in the most recent macos update to break this
@dantswain dantswain merged commit 9c93293 into master Oct 13, 2019
@dantswain dantswain deleted the kayrock_error_messages branch October 13, 2019 16:03
@joshuawscott joshuawscott mentioned this pull request Jul 14, 2020
Merged
robotarmy pushed a commit to RAM9/kafka_ex that referenced this pull request Apr 7, 2025
@dantswain
Merge pull request kafkaex#377 from kafkaex/kayrock_error_messages
80eb00c 
Version bump Kayrock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuawscott joshuawscott joshuawscott approved these changes

@bjhaid bjhaid Awaiting requested review from bjhaid

@jbruggem jbruggem Awaiting requested review from jbruggem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantswain @joshuawscott
0