Automatically trigger passkeys on login view #3307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an on-load handler to pkhtml.js so that when the partial view is displayed passkey auth is automatically prompted for. If the users browser blocks this event, the fallback manual buttons still exist.
|
Sorry @CEbbinghaus this PR is 3 times larger than you'd like. |
CEbbinghaus
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Ugh, I cannot believe you are adding code 😒, that is so early 2000's of you. we really should have a policy that requires at minimum lines added == lines deleted 😉
FR tho I cannot believe this is all it took to get the popup coming up automatically. Or is this a browser dependent thing on whether it lets us prompt for passkeys without user interaction?
|
Surprisingly it works in safari which was the problem child of all the browsers. I tested it as working on ff, safari and chromium. |
Firstyear
added a commit
that referenced
this pull request
Dec 21, 2024
Add an on-load handler to pkhtml.js so that when the partial view is displayed passkey auth is automatically prompted for. If the users browser blocks this event, the fallback manual buttons still exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3193
Checklist