8000 #3387 - RADIUS Startup fixin's by yaleman · Pull Request #3388 · kanidm/kanidm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

#3387 - RADIUS Startup fixin's #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 4, 2025
Merged

#3387 - RADIUS Startup fixin's #3388

merged 11 commits into from
Feb 4, 2025

Conversation

yaleman
Copy link
Member
@yaleman yaleman commented Feb 3, 2025

Change summary

  • updates RADIUS docs
  • updates kanidm Python things to be less terrible and work
  • updates the RADIUS container build to ... work

Fixes #3387

Checklist

  • This PR contains no AI generated code
  • book chapter included (if relevant)
  • design document included (if relevant)

@yaleman yaleman requested a review from Firstyear February 3, 2025 07:22
@yaleman yaleman mentioned this pull request Feb 3, 2025
Closed
CEbbinghaus
CEbbinghaus previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator
@CEbbinghaus CEbbinghaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing glaringly bad. @Firstyear would probably find more subtle problems

CEbbinghaus
CEbbinghaus previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator
@CEbbinghaus CEbbinghaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from -v I see no problems with this <3

Firstyear
Firstyear requested changes Feb 4, 2025
View reviewed changes
@Firstyear
Copy link
Member

Okay, I'll test this against my radius setup quickly.

@Firstyear
Copy link
Member 
FileNotFoundError: Failed to find configuration file (/data/radius.toml), quitting!
Traceback (most recent call last):
  File "/radius_entrypoint.py", line 158, in <module>
    kanidm_config = KanidmClientConfig.model_validate(load_config(kanidm.radius.CONTAINER_CONFIG_FILE_PATH))
                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/kanidm/utils.py", line 17, in load_config
    raise FileNotFoundError(
FileNotFoundError: Failed to find configuration file (/data/radius.toml), quitting!
Traceback (most recent call last):
  File "/radius_entrypoint.py", line 158, in <module>
    kanidm_config = KanidmClientConfig.model_validate(load_config(kanidm.radius.CONTAINER_CONFIG_FILE_PATH))
                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/kanidm/utils.py", line 17, in load_config
    raise FileNotFoundError(
FileNotFoundError: Failed to find configuration file (/data/radius.toml), quitting!

Sad radius sounds.

Firstyear
Firstyear reviewed Feb 4, 2025
View reviewed changes
@yaleman
Copy link
Member Author
yaleman commented Feb 4, 2025 
FileNotFoundError: Failed to find configuration file (/data/radius.toml), quitting!
Traceback (most recent call last):
  File "/radius_entrypoint.py", line 158, in <module>
    kanidm_config = KanidmClientConfig.model_validate(load_config(kanidm.radius.CONTAINER_CONFIG_FILE_PATH))
                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/kanidm/utils.py", line 17, in load_config
    raise FileNotFoundError(
FileNotFoundError: Failed to find configuration file (/data/radius.toml), quitting!
Traceback (most recent call last):
  File "/radius_entrypoint.py", line 158, in <module>
    kanidm_config = KanidmClientConfig.model_validate(load_config(kanidm.radius.CONTAINER_CONFIG_FILE_PATH))
                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/kanidm/utils.py", line 17, in load_config
    raise FileNotFoundError(
FileNotFoundError: Failed to find configuration file (/data/radius.toml), quitting!

Sad radius sounds.

Didn't read the docs sounds 😄

@Firstyear
Copy link
Member

Yeah, but people upgrading will get bitten by this if we change it, so we should have the fall back there.

@Firstyear
Copy link
Member

Thanks, testing now :)

Firstyear
Firstyear approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member
@Firstyear Firstyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this as working :)

Thanks!

@yaleman yaleman enabled auto-merge (squash) February 4, 2025 06:21
@yaleman yaleman disabled auto-merge February 4, 2025 09:15
@yaleman yaleman enabled auto-merge (squash) February 4, 2025 09:16
@yaleman yaleman merged commit 3b3c029 into kanidm:master Feb 4, 2025
23 checks passed
@yaleman yaleman deleted the 3387 branch February 4, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Firstyear Firstyear Firstyear approved these changes

@CEbbinghaus CEbbinghaus CEbbinghaus left review comments

Assignees
No one assigned
Labels
None yet
Projects
Organising Everything
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permission and Configuration Issues with Kanidm RADIUS Container
3 participants
@yaleman @Firstyear @CEbbinghaus
0