OpenBSD support #3381
OpenBSD support #3381
Conversation
|
I'd say stub them out using similar cfg flags to what we use to avoid trying to build on windows etc, eg: kanidm/unix_integration/pam_kanidm/src/lib.rs Lines 14 to 15 in 1453ba5 |
Yeah, tried that, but then |
|
Hey if you can make it work with OpenPAM (on just OpenBSD), and want to maintain it, you're welcome to 😄 |
Sure, can do, will work on that next. Anyhow, is there something else required for this pull request to go forward? I'd like to have those things separate, as this adds OpenBSD support regardless of what is decided with pam module. |
|
Looks good to me, can you rebase it and add yourself to the contributors file and we can merge it. |
b2872b4 to
ecdf573
Compare
✔️ |
ecdf573 to
a2ffd95
Compare
|
@arthepsy Sounds awesome, we'd love to see openbsd support here. Perhaps open an issue so we can track the work and what's needed? Thank you! |
Great! And I'm willing to help make this happen. What kind of issue You had in mind (just so that I do everything correctly) - labels, tags, etc.? |
|
@arthepsy Done, made a bsd label for you. but we're pretty chill about it, just as long as we can see what's going on :) You may be interested in: #3404 which resolves some nss issues on freebsd that it looks like openbsd would have hit also. I was looking into it and I think we'd need a login_-kanidm next for login.conf on openbsd? |
Implement OpenBSD support
With this patch compiles and runs fine on OpenBSD 7.6, rust 1.81.0. Did basic tests, all good, no issues.
Had to install
openssl-3.3.2, because there were multiple failures (in various dependencies) using OpenBSD'slibressl, but that's about it.Only exception is
unix_integrations/pam_kanidm(OpenBSD doesn't have built-in PAM), which I just commented out inCargo.toml, when building and everything was build successfully.Regarding this, I had an idea to rework
Cargo.tomlto exclude this while building on OpenBSD, but it seems that it isn't supported by cargo (read multiple issues by people requesting it, checked ignored pull requests, etc.) or my knowledge how to do is lacking. Maybe this can be reworked some-how (ab)usingfeatures, but that's to be researched. Anyhow, I think the best case would be to reworkpam_kanidmfor OpenBSD to use OpenPAM, which is available as a package.Please, give feedback about how to handle
pam_kanidmfor OpenBSD, so I can work on this.Checklist