Handle form-post as a response mode #3467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some oauth2 clients apparently ignore what we tell them and request response modes we don't support. First, we should deserialise these and error correctly. Second, to maintain temporary compatibility, we remap form-post to query. This will be removed in future.
yaleman
approved these changes
Mar 5, 2025
CEbbinghaus
reviewed
Mar 9, 2025
| warn!( | ||
| "Invalid response mode form_post requested - many clients request this incorrectly but proceed with response_mode=query. Remapping to query." | ||
| ); | ||
| warn!("This behaviour WILL BE REMOVED in a future release."); |
There was a problem hiding this comment.
sorry to necro but this is gonna be a hard sell. Once we support it removing support for it becomes significantly harder given that we would be breaking people's existing working setups.
There was a problem hiding this comment.
We've done it before - before we remove it, we can convert it to a compatibility boolean, and then gauge affected users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some oauth2 clients apparently ignore what we tell them and request response modes we don't support.
First, we should deserialise these and error correctly.
Second, to maintain temporary compatibility, we remap form-post to query. This will be removed in future.
Fixes #3461
Checklist