8000 Defend against split_at panic by Firstyear · Pull Request #3636 · kanidm/kanidm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Defend against split_at panic #3636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Defend against split_at panic #3636

merged 1 commit into from
May 14, 2025

Conversation

Firstyear
Copy link
Member
@Firstyear Firstyear commented May 14, 2025 •
edited
Loading

Change summary

  • Fix hint parsing in cred import
  • Review all other uses of split_at, and confirm they are valid.

Fixes #3635

Checklist

  • This PR contains no AI generated code
  • book chapter included (if relevant)
  • design document included (if relevant)

@Firstyear Firstyear marked this pull request as ready for review May 14, 2025 09:23
@Firstyear Firstyear requested a review from yaleman May 14, 2025 09:23
yaleman
yaleman approved these changes May 14, 2025
View reviewed changes
Copy link
Member
@yaleman yaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Winning! Less assumptions more better.

@github-project-automation github-project-automation bot moved this from 🆕 New to 🔖 Ready in Organising Everything May 14, 2025
@yaleman yaleman merged commit 13c3be5 into kanidm:master May 14, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Organising Everything May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaleman yaleman yaleman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Organising Everything
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server panicks when importing from LDAP
2 participants
@Firstyear @yaleman
0