OpenStack: Fix VM deletion #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting an OpenStack instance, for example the bootstrap node when deploying OCP or OCP itself on cluster cleanup, we are likely to encounter an error similar to this one: ``` cinderclient.exceptions.ClientException: ConflictNovaUsingAttachment: Detach volume from instance 0b54b909-43d8-4968-a183-c82004ad1e2e using the Compute API (HTTP 409) (Request-ID: req-2f8babd2-3aac-491e-83fa-032810da8880) ``` Which is caused by kcli being too fast to delete the volumes and requesting their deletion before the VM has actually stopped using them. This patch fixes this by making sure we don't try to delete volumes until the nova instance has disappeared, at which point its resources would have been freed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting an OpenStack instance, for example the bootstrap node when deploying OCP or OCP itself on cluster cleanup, we are likely to encounter an error similar to this one:
Which is caused by kcli being too fast to delete the volumes and requesting their deletion before the VM has actually stopped using them.
This patch fixes this by making sure we don't try to delete volumes until the nova instance has disappeared, at which point its resources would have been freed.