8000 karakeep-linux.sh fix: use 'append' instead of 'file' for logs by vhsdream · Pull Request #1471 · karakeep-app/karakeep · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

karakeep-linux.sh fix: use 'append' instead of 'file' for logs #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025

Conversation

vhsdream
Copy link
Contributor
@vhsdream vhsdream commented May 26, 2025

I noticed that using the log for StdOut and StdError would stop working under certain circumstances. Using 'append' instead of 'file' allows the file to be read while opened.

@vhsdream vhsdream marked this pull request as draft May 27, 2025 16:43
@vhsdream vhsdream changed the title karakeep-linux.sh fix: use journal for logging karakeep-linux.sh fix: use 'append' instead of 'file' for logs May 28, 2025
@vhsdream vhsdream marked this pull request as ready for review May 28, 2025 18:35
@MohamedBassem
Copy link
Collaborator

My slight concern of the use of append is that the log file will probably grow indefinitely because there's no log rotation set up, right?

@vhsdream vhsdream force-pushed the logging-fix branch 2 times, most recently from 6df3243 to afa0e3c Compare June 3, 2025 17:04
@vhsdream
Copy link
Contributor Author
vhsdream commented Jun 3, 2025

My slight concern of the use of append is that the log file will probably grow indefinitely because there's no log rotation set up, right?

Sorry about the delay - there is now 😄

- Noticed that using the log for StdOut and StdError would stop working
under certain circumstances.
- Using append is the correct setting so output can be read while
tailing the logs
@MohamedBassem MohamedBassem merged commit 09e5dd6 into karakeep-app:main Jun 7, 2025
5 checks passed
@MohamedBassem
Copy link
Collaborator

Thank you!

@vhsdream vhsdream deleted the logging-fix branch June 9, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0