R2 #4
Open
R2 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated for Yosemite
To fix the build of the JNI libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version is mostly complete. It adds support for lists, trees, tables, titled borders, tabbed panes, buttons, split panes, and separators to the existing support for the file chooser and the color chooser.
Try it using -DQuaqua.LAF=Yosemite.18
Some changes to the existing code base were made to enable code reuse. Those changes would most benefit from a second pair of eyes.
Known issues:
Checkboxes and radio buttons do not use Yosemite style. [This requires a fix to the JavaRuntimeSupport framework or else wholesale replacement.]
The standard button style does not match Yosemite style.
Color well buttons are not implemented.
Table header buttons are not implemented. [Not sure if they are needed.]
Square toggle button style is not implemented. [Not sure if they are needed.]
Gradient toggle button style is not implemented. [Not sure if they are needed.]
Palettes display three title bar buttons instead of one. The extra buttons can be disabled. Vertical orientation is not supported.
Split pane divider arrows are not HiDPI capable.
Small and mini combo box text is positioned too high. [may not be fixable short of wholesale replacement]
Segmented toggle buttons: text positioned too low in small size. Small and mini could be narrower.
Special Text Field: Margin example does not look right.