8000 Parameters Required by psionic-k · Pull Request #600 · karthink/gptel · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Parameters Required #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2025
Merged

Parameters Required #600

merged 2 commits into from
Feb 1, 2025

Conversation

psionic-k
Copy link
Contributor 
:TOOL_CALL:
(all_arg_types (:foo 42))

object: (:foo 42)

💥

:shipit:

Related tool example found here

I found this by inspecting the tool use and noticing a :parameters nil in the plist describing the tool to the backend. The object spec wasn't being given to the backend at all.

@psionic-k
in request, object parameters -> properties
7f7d714 
While the tool arguments are named "parameters", a parameter that is an object
wil use "properties".
@psionic-k psionic-k mentioned this pull request Feb 1, 2025
Closed
karthink
karthink reviewed Feb 1, 2025
View reviewed changes
@karthink
Copy link
Owner
karthink commented Feb 1, 2025

Thanks for catching this.

@psionic-k
include required in object type tool parameters
3dcf860 
"required" is stated to be required in the documents.

Combined with the previous commit, the model now succeeds at calling my tool.
@psionic-k psionic-k force-pushed the parameters-required branch from 2eda329 to 3dcf860 Compare February 1, 2025 09:35
@karthink karthink merged commit c530f8a into karthink:master Feb 1, 2025
@karthink
Copy link
Owner
karthink commented Feb 1, 2025 •
edited
Loading

I found this by inspecting the tool use and noticing a :parameters nil in the plist describing the tool to the backend.

In case you weren't aware: you can inspect the query payload from the transient menu. (Set gptel-expert-commands to t.)

image

In this case the bug showed up in the query payload. You only need to actually send requests to check how the LLM responds or aspects of response handling.

@psionic-k psionic-k deleted the parameters-required branch March 5, 2025 08:22
marcbowes pushed a commit to marcbowes/gptel that referenced this pull request Mar 19, 2025
@psionic-k
gptel-openai: Encode object args in tools correctly (karthink#600)
0a3692c 
gptel.el (gptel--parse-tools): Ensure that the
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthink karthink karthink left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psionic-k @karthink
0