gptel-transient: Fix face related bug #638
Conversation
- gptel-transient (gptel-menu): Fix a slight bug introduced in commit edf834a ("Provide description of send action") where an extra quote (') caused error "Invalid face reference: quote" to appear in Messages and the "Context" heading to have incorrect face (color).
| @@ -550,7 +550,7 @@ Also format its value in the Transient menu." | |||
| (gptel--infix-add-directive)] | |||
| [:pad-keys t "" | |||
| (:info #'gptel--describe-infix-context | |||
There was a problem hiding this comment.
I think the #' in #'gptel--describe-infix-context is not required either, as everything is quoted by default here.
There was a problem hiding this comment.
I think the
#'in#'gptel--describe-infix-contextis not required either, as everything is quoted by default here.
Noted, seems to work and byte-compilation is is happy.
There was a problem hiding this comment.
I meant that it should be unquoted, so just gptel--describe-infix-context, without the '.
8000
There was a problem hiding this comment.
I meant that it should be unquoted, so just
gptel--describe-infix-context, without the'.
Nope:
list: Symbol’s value as variable is void: gptel--describe-infix-context
I think the # should be there as well for proper elisp convention, right?
There was a problem hiding this comment.
Sorry, my bad. In that case the # should also be present, please add it back in.
I'm confused about the quoting convention inside Transient group definitions now, though.
* gptel-transient (gptel-menu): Fix a slight bug introduced in commit edf834a ("Provide description of send action") where an extra quote (') caused error "Invalid face reference: quote" to appear in *Messages* and the "Context" heading to have incorrect face (color).
|
Thank you @pabl0! |
* gptel-transient (gptel-menu): Fix a slight bug introduced in commit edf834a ("Provide description of send action") where an extra quote (') caused error "Invalid face reference: quote" to appear in *Messages* and the "Context" heading to have incorrect face (color).