gptel: Ensure restoring state does not flag the buffer modified #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* gptel.el (gptel--restore-props): Save `buffer-modified-p' before restoring properties and revert it to its original state. This prevents a visited file from being marked as modified until the user actually makes changes. This is particularly useful when multiple files are accessed automatically, such as from the `org-agenda-files' location (otherwise when exiting Emacs the user is asked about each file if it needs to be saved). * gptel-org.el (gptel-org--restore-state): Likewise for Org.
|
I can see this creating some edge case issues involving file-locking in the future, but we'll revisit that when it crops up. Thanks for the PR @pabl0! |
|
Of course I just learned about the macro `with-silent-modification' that is the correct way of doing this, I suppose. |
|
Yeah that would be the better way, but we can leave it be for now
…On Mon, Mar 17, 2025, 3:07 PM Henrik Ahlgren ***@***.***> wrote:
Of course I just learned about the macro `with-silent-modification' that
is the correct way of doing this, I suppose.
It might help with potential locking issues, but have to look into it in
more detail.
—
Reply to this email directly, view it on GitHub
<#711 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBVOLC7WII4SHY7LPSWTD32U5BT7AVCNFSM6AAAAABZD7U62CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZRGA2DGMJTGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
[image: pabl0]*pabl0* left a comment (karthink/gptel#711)
<#711 (comment)>
Of course I just learned about the macro `with-silent-modification' that
is the correct way of doing this, I suppose.
It might help with potential locking issues, but have to look into it in
more detail.
—
Reply to this email directly, view it on GitHub
<#711 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBVOLC7WII4SHY7LPSWTD32U5BT7AVCNFSM6AAAAABZD7U62CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZRGA2DGMJTGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
marcbowes
pushed a commit
to marcbowes/gptel
that referenced
this pull request
Mar 19, 2025
) * gptel.el (gptel--restore-props): Save `buffer-modified-p' before restoring properties and revert it to its original state. This prevents a visited file from being marked as modified until the user actually makes changes. This is particularly useful when multiple files are accessed automatically, such as from the `org-agenda-files' location (otherwise when exiting Emacs the user is asked about each file if it needs to be saved). * gptel-org.el (gptel-org--restore-state): Likewise for Org.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gptel.el (gptel--restore-props): Save
buffer-modified-pbefore restoring properties and revert it to its original state. This prevents a visited file from being marked as modified until the user actually makes changes. This is particularly useful when multiple files are accessed automatically, such as from theorg-agenda-fileslocation (otherwise when exiting Emacs the user is asked about each file if it needs to be saved).gptel-org.el (gptel-org--restore-state): Likewise for Org.