8000 fix: readonly string array error for enum option by kazupon · Pull Request #106 · kazupon/gunshi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: readonly string array error for enum option #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025
Merged

Conversation

kazupon
Copy link
Owner
@kazupon kazupon commented May 3, 2025

Description

Linked Issues

resolve #103

related fixed PR: kazupon/args-tokens#81

Additional context

@kazupon kazupon added the bug Includes new features label May 3, 2025
Copy link

Deploying gunshi with  Cloudflare Pages  Cloudflare Pages

Latest commit: 141a1f6
Status: ✅  Deploy successful!
Preview URL: https://c281a3fa.gunshi.pages.dev
Branch Preview URL: https://fix-type-errors-1.gunshi.pages.dev

View logs

@kazupon kazupon requested a review from Copilot May 3, 2025 09:35
Copy link
pkg-pr-new bot commented May 3, 2025

Open in StackBlitz

npm i https://pkg.pr.new/kazupon/gunshi@106

commit: 141a1f6

Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with readonly string array errors when using enum options by introducing a new test.

  • Added a new test case for enum option defaults using a readonly choices array.
  • Imported the necessary modules to support the test.
Files not reviewed (2)
  • package.json: Language not supported
  • pnpm-lock.yaml: Language not supported

@kazupon kazupon merged commit 6369ab8 into main May 3, 2025
9 checks passed
@kazupon kazupon deleted the fix/type-errors-1 branch May 3, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Includes new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readonly string array causes type error for choices
1 participant
0