-
-
Notifications
You must be signed in to change notification settings - Fork 3
fix: move to tsgo #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move to tsgo #132
Conversation
WalkthroughThe script for TypeScript type checking in the project was updated to use Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
commit: |
Deploying gunshi with
|
Latest commit: |
f151895
|
Status: | ✅ Deploy successful! |
Preview URL: | https://22d1a729.gunshi.pages.dev |
Branch Preview URL: | https://feat-tsgo.gunshi.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Cloudflare Pages
@@ -108,7 +108,7 @@ | |||
"test": "vitest --typecheck run", | |||
"typecheck": "pnpm run --stream --color \"/^typecheck:/\"", | |||
"typecheck:deno": "deno check --all ./src", | |||
"typecheck:tsc": "tsc --noEmit" | |||
"typecheck:tsc": "tsgo --noEmit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Ensure tsgo
is declared and consider renaming the script
The "typecheck:tsc"
script now invokes tsgo
, but there’s no tsgo
entry under devDependencies
, so CI will break on fresh installs. Please add tsgo
(pinned to a specific version) to your devDependencies
. Additionally, renaming the script key from typecheck:tsc
to typecheck:tsgo
could prevent confusion.
Run this to verify whether tsgo
is already declared:
🏁 Script executed:
#!/usr/bin/env bash
# Check if tsgo is listed in devDependencies
jq '.devDependencies.tsgo' package.json
Length of output: 44
Add missing tsgo
dependency and rename the script
The "typecheck:tsc"
script invokes tsgo
, but it isn’t declared in devDependencies
, so CI will break on fresh installs. Please:
- In
package.json
underdevDependencies
, add a pinned version oftsgo
(e.g."tsgo": "^0.1.0"
). - Rename the script key to match the tool you’re calling:
"scripts": {
- "typecheck:tsc": "tsgo --noEmit"
- "typecheck:tsgo": "tsgo --noEmit"
}
> Committable suggestion skipped: line range outside the PR's diff.
<details>
<summary>🤖 Prompt for AI Agents</summary>
In package.json at line 111, the script "typecheck:tsc" calls "tsgo" which is
not declared in devDependencies, causing CI failures on fresh installs. Add
"tsgo" with a pinned version (e.g., "^0.1.0") to the devDependencies section and
rename the script key
8000
from "typecheck:tsc" to "typecheck:tsgo" to accurately
reflect the tool being used.
</details>
<!-- This is an auto-generated comment by CodeRabbit -->
@@ -119,6 +119,7 @@ | |||
"@kazupon/eslint-config": "^0.29.0", | |||
"@kazupon/prettier-config": "^0.1.1", | |||
"@types/node": "^22.15.18", | |||
"@typescript/native-preview": "7.0.0-dev.20250522.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Validate the new @typescript/native-preview
dependency
You’ve replaced typescript
with a preview package. Ensure the version 7.0.0-dev.20250522.2
actually exists in the npm registry and that all tooling (editor integrations, CI pipelines, etc.) supports it. If this is a temporary measure, consider documenting the migration or pinning to a non-preview version when available.
Run this to confirm version availability:
🏁 Script executed:
#!/usr/bin/env bash
# Check if the preview version exists on npm
curl -s https://registry.npmjs.org/@typescript%2Fnative-preview | jq '.versions | has("7.0.0-dev.20250522.2")'
Length of output: 117
Verify npm registry and update documentation
Our check confirms that @typescript/native-preview@7.0.0-dev.20250522.2
is published in the npm registry. Before merging, please:
- Test all tooling: ensure your editor plugins, build scripts, and CI pipelines correctly resolve and compile against this preview package.
- Document the migration: add a note in your README or a dedicated migration guide explaining why you’re using the preview release and how to revert or upgrade once a stable version is available.
- Pin to a stable version when possible: plan to replace the preview package with an official release to minimize future surprises.
Files to review/update:
package.json
(line 122) – version declaration- Project documentation (e.g.,
README.md
or aMIGRATION.md
)
🤖 Prompt for AI Agents
In package.json at line 122, you have added the preview dependency
"@typescript/native-preview" with version "7.0.0-dev.20250522.2". Confirm this
version exists in the npm registry and then test all related tooling such as
editor integrations, build scripts, and CI pipelines to ensure compatibility.
Additionally, update project documentation like README.md or create a
MIGRATION.md to explain the use of this preview package and provide guidance on
reverting or upgrading to a stable version. Plan to replace this preview
dependency with a stable release when it becomes available.
Description
Linked Issues
Additional context
Summary by CodeRabbit