8000 fix: move to tsgo by kazupon · Pull Request #132 · kazupon/gunshi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: move to tsgo #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

fix: move to tsgo #132

merged 1 commit into from
May 22, 2025

Conversation

kazupon
Copy link
Owner
@kazupon kazupon commented May 22, 2025

Description

Linked Issues

Additional context

Summary by CodeRabbit

  • Chores
    • Updated development dependencies related to TypeScript.
    • Modified the script command for type checking.

Copy link
Contributor
coderabbitai bot commented May 22, 2025

Walkthrough

The script for TypeScript type checking in the project was updated to use tsgo instead of tsc, and the development dependency on typescript was replaced with @typescript/native-preview. No other scripts or dependencies were altered.

Changes

File Change Summary
package.json Updated type check script to use tsgo --noEmit. Removed typescript devDependency. Added @typescript/native-preview as a new devDependency.

Poem

A hop and a skip, the scripts take flight,
With tsgo now checking types just right.
Old TypeScript bids a gentle adieu,
While native-preview hops into view.
In the warren of code, dependencies renew!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
pkg-pr-new bot commented May 22, 2025

Open in StackBlitz

npm i https://pkg.pr.new/kazupon/gunshi@132

commit: f151895

Copy link

Deploying gunshi with  Cloudflare Pages  Cloudflare Pages

Latest commit: f151895
Status: ✅  Deploy successful!
Preview URL: https://22d1a729.gunshi.pages.dev
Branch Preview URL: https://feat-tsgo.gunshi.pages.dev

View logs

Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 703acad and f151895.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Cloudflare Pages

@@ -108,7 +108,7 @@
"test": "vitest --typecheck run",
"typecheck": "pnpm run --stream --color \"/^typecheck:/\"",
"typecheck:deno": "deno check --all ./src",
"typecheck:tsc": "tsc --noEmit"
"typecheck:tsc": "tsgo --noEmit"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Ensure tsgo is declared and consider renaming the script
The "typecheck:tsc" script now invokes tsgo, but there’s no tsgo entry under devDependencies, so CI will break on fresh installs. Please add tsgo (pinned to a specific version) to your devDependencies. Additionally, renaming the script key from typecheck:tsc to typecheck:tsgo could prevent confusion.

Run this to verify whether tsgo is already declared:


🏁 Script executed:

#!/usr/bin/env bash
# Check if tsgo is listed in devDependencies
jq '.devDependencies.tsgo' package.json

Length of output: 44


Add missing tsgo dependency and rename the script
The "typecheck:tsc" script invokes tsgo, but it isn’t declared in devDependencies, so CI will break on fresh installs. Please:

  • In package.json under devDependencies, add a pinned version of tsgo (e.g. "tsgo": "^0.1.0").
  • Rename the script key to match the tool you’re calling:
    "scripts": {
  • "typecheck:tsc": "tsgo --noEmit"
  • "typecheck:tsgo": "tsgo --noEmit"
    }


> Committable suggestion skipped: line range outside the PR's diff.

<details>
<summary>🤖 Prompt for AI Agents</summary>

In package.json at line 111, the script "typecheck:tsc" calls "tsgo" which is
not declared in devDependencies, causing CI failures on fresh installs. Add
"tsgo" with a pinned version (e.g., "^0.1.0") to the devDependencies section and
rename the script key 8000 from "typecheck:tsc" to "typecheck:tsgo" to accurately
reflect the tool being used.


</details>

<!-- This is an auto-generated comment by CodeRabbit -->

@@ -119,6 +119,7 @@
"@kazupon/eslint-config": "^0.29.0",
"@kazupon/prettier-config": "^0.1.1",
"@types/node": "^22.15.18",
"@typescript/native-preview": "7.0.0-dev.20250522.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Validate the new @typescript/native-preview dependency
You’ve replaced typescript with a preview package. Ensure the version 7.0.0-dev.20250522.2 actually exists in the npm registry and that all tooling (editor integrations, CI pipelines, etc.) supports it. If this is a temporary measure, consider documenting the migration or pinning to a non-preview version when available.

Run this to confirm version availability:


🏁 Script executed:

#!/usr/bin/env bash
# Check if the preview version exists on npm
curl -s https://registry.npmjs.org/@typescript%2Fnative-preview | jq '.versions | has("7.0.0-dev.20250522.2")'

Length of output: 117


Verify npm registry and update documentation
Our check confirms that @typescript/native-preview@7.0.0-dev.20250522.2 is published in the npm registry. Before merging, please:

  • Test all tooling: ensure your editor plugins, build scripts, and CI pipelines correctly resolve and compile against this preview package.
  • Document the migration: add a note in your README or a dedicated migration guide explaining why you’re using the preview release and how to revert or upgrade once a stable version is available.
  • Pin to a stable version when possible: plan to replace the preview package with an official release to minimize future surprises.

Files to review/update:

  • package.json (line 122) – version declaration
  • Project documentation (e.g., README.md or a MIGRATION.md)
🤖 Prompt for AI Agents
In package.json at line 122, you have added the preview dependency
"@typescript/native-preview" with version "7.0.0-dev.20250522.2". Confirm this
version exists in the npm registry and then test all related tooling such as
editor integrations, build scripts, and CI pipelines to ensure compatibility.
Additionally, update project documentation like README.md or create a
MIGRATION.md to explain the use of this preview package and provide guidance on
reverting or upgrading to a stable version. Plan to replace this preview
dependency with a stable release when it becomes available.

@kazupon kazupon merged commit 0cc14fb into main May 22, 2025
10 checks passed
@kazupon kazupon deleted the feat/tsgo branch May 22, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0