8000 fix: wrong publish by kazupon · Pull Request #154 · kazupon/gunshi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: wrong publish #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

fix: wrong publish #154

merged 2 commits into from
May 30, 2025

Conversation

kazupon
Copy link
Owner
@kazupon kazupon commented May 30, 2025 •
edited by coderabbitai bot
Loading

Description

Linked Issues

Additional context

Summary by CodeRabbit

  • Chores
    • Updated the release process to ensure that key files and assets are included when publishing the gunshi package.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 30, 2025 •
edited
Loading

Walkthrough

The release script was updated to include a conditional step for the packages/gunshi package. Before publishing, it now copies the assets directory and several documentation files (README.md, CHANGELOG.md, and LICENSE) into the package directory. No other packages or publishing steps were changed.

Changes

File(s) Change Summary
scripts/release.sh Added conditional logic to copy assets, README.md, CHANGELOG.md, and LICENSE to gunshi before publishing.

Poem

A hop and a skip, the script takes flight,
Copying assets in the dead of night.
README and license now join the run,
Gunshi’s release prep is nearly done!
With files in tow, the code hops free—
A bunny’s work, as neat as can be! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 446d5ba and b67d666.

📒 Files selected for processing (1)
  • scripts/release.sh (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • scripts/release.sh
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Cloudflare Pages
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new pkg.pr.new
Copy link
pkg-pr-new bot commented May 30, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/gunshi@154

commit: b67d666

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link
cloudflare-workers-and-pages bot commented May 30, 2025 •
edited
Loading

Deploying gunshi with  Cloudflare Pages  Cloudflare Pages

Latest commit: b67d666
Status: ✅  Deploy successful!
Preview URL: https://efeda0ef.gunshi.pages.dev
Branch Preview URL: https://fix-wrong-publish.gunshi.pages.dev

View logs

coderabbitai[bot]
coderabbitai bot reviewed May 30, 2025
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
scripts/release.sh (2)

24-27: Refactor: Consolidate copy commands using brace expansion

You can simplify and reduce repetition by combining the file copy commands:

-      cp -r ../../assets ./assets
-      cp ../../README.md ./README.md
-      cp ../../CHANGELOG.md ./CHANGELOG.md
-      cp ../../LICENSE ./LICENSE
+      cp -r ../../assets ./assets
+      cp ../../{README.md,CHANGELOG.md,LICENSE} .

This makes it more concise and easier to maintain if additional files are added in the future.

23-28: Nitpick: Log before copying assets and docs

It may be helpful to emit an informational message before copying to improve traceability during the release process:

-    if [[ $PKG == packages/gunshi ]]; then
+    if [[ $PKG == packages/gunshi ]]; then
+      echo "📦 Preparing gunshi: copying assets and documentation..."

This provides visibility into what the script is doing in CI logs.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53d1045 and 446d5ba.

📒 Files selected for processing (1)
  • scripts/release.sh (1 hunks)

@kazupon @coderabbitai
Update scripts/release.sh
b67d666 
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@kazupon kazupon merged commit d3a02d7 into main May 30, 2025
10 checks passed
@kazupon kazupon deleted the fix/wrong-publish branch May 30, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kazupon
0