Renamed input parameters to Leaf.make function to avoid shadowing #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaf library has operator, creationBlock, and weight functions and they were shadowed in make function by input parameters with the same name. Added underscores to parameter names to avoid shadowing.
nkuba
approved these changes
Aug 25, 2020
nkuba
added a commit
that referenced
this pull request
Aug 28, 2020
Bumping up version to 1.1.1 for a new release The new release will contain no functionality changes but will re-organize the code based on Linter and Slither suggestions: - Update linting configuration #87 - Small loop refactor to make Slither happier #90 - Renamed input parameters to Leaf.make function to avoid shadowing #91 See https://github.com/keep-network/sortition-pools/milestone/4?closed=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaflibrary hasoperator,creationBlock, andweightfunctions and they were shadowed inmakefunction by input parameters with the same name. Added underscores to parameter names to avoid shadowing.