View with custom state, iteration #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the
GridandViewfunctionality, including the introduction of a newObserverinterface and the refactoring of theViewstructure to support state and type parameters. The most important changes are outlined below:Refactoring and New Functionality:
view.go: Introduced a newObserverinterface and refactored theViewstructure to support state and type parameters. TheNewViewfunction now creates a view with a given state, and theResize,MoveTo,MoveBy,MoveAt,Each,At,WriteAt,MergeAt, andClosemethods have been updated to use the new structure. [1] [2] [3] [4] [5] [6] [7]Observer Handling:
grid.go: Removed theViewmethod from theGridstructure and added theObserversmethod to theTilestructure to iterate over all views observing a tile. [1] [2]Utility Functions:
point.go: AddedpackandunpackRectmethods to theRectstructure for packing and unpacking rectangle representations.Documentation Update:
README.md: Updated the documentation to reflect the changes fromViewtoNewViewand provided additional information on the type parameters for theNewViewfunction.