Check for both points when moving within viewport #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug when the update isn't correctly fired when entering the viewport from one side. This is due to the contains check that wasn't checking properly for both before/after points.
Simplification and Refactoring:
atparameter inwriteTile,mergeTile,Add,Del, andMovemethods ingrid.go. [1] [2] [3] [4] [5]Observersmethod inTileto improve readability and efficiency.atandlocsparameters inNotify1,Notify2,Each1, andEach2methods inview.go. [1] [2]Test Suite Enhancements:
TestView_Updatesto cover various edge cases for theMovemethod inview_test.go.TestObserversto clean up the test suite.