Increase pathfinder map fill ratio to 0.99 and update dependencies #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates dependencies, improves the pathfinder’s memory usage via a higher fill ratio, and updates benchmark results to reflect the performance changes.
- Updated Go version and intmap dependency in go.mod
- Modified pathfinder edges initialization to use a fill factor of 0.99
- Adjusted benchmark results in path_test.go to match the new pathfinder behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| path_test.go | Updated benchmark numbers to reflect new performance and memory usage |
| path.go | Changed initialization of edges to use intmap.NewWithFill with fill .99 |
| go.mod | Updated Go version and intmap dependency version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates dependencies, modifies the pathfinding logic to improve performance, and updates benchmark results to reflect these changes. The most important changes are summarized below.
Dependency Updates:
go.modfrom 1.23 to 1.24 and bumped thegithub.com/kelindar/intmapdependency from v1.4.1 to v1.5.0.Pathfinding Logic Enhancements:
pathfinderstruct'sedgesinitialization to useintmap.NewWithFillwith a fill factor of 0.99 instead of 0.95, improving memory usage efficiency. [1] [2]Benchmark Updates:
path_test.goto reflect improved performance and memory usage after the changes to thepathfinderlogic.