Ignore HTTP::Server::Response patching for crystal >= 1.3.0 #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @SamantazFox , nice catch 👍 I'm just curious how we can improve / remove this to handle the future Crystal versions 🤔 |
straight-shoota
approved these changes
Feb 22, 2022
sdogruyol
approved these changes
Feb 22, 2022
mamantoha
approved these changes
Feb 22, 2022
|
Just cut the release v1.1.1 https://github.com/kemalcr/kemal/releases/tag/v1.1.1 |
SamantazFox
added a commit
to iv-org/invidious
that referenced
this pull request
Feb 22, 2022
Solves breakon playback on crystal 1.3.* See: kemalcr/kemal#628 Closes: #2783
SamantazFox
added a commit
to SamantazFox/invidious
that referenced
this pull request
Feb 23, 2022
Solves broken playback on crystal 1.3.* See: kemalcr/kemal#628 Closes: iv-org#2783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #627