Closes response by default in HTTP::Server::Context#redirect #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #638 |
|
I'm not sure if this needs to be configurable. I'd be happy with always closing the response. But it's probably fine to have the option. |
9bd24ca
into
kemalcr:master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes HTTP::Server::Response by default in HTTP::Server::Context#redirect
Alternate Designs
Does not close response by default with option to override it.
Benefits
Redirections in before filters would skip processing in RouteHandler
Possible Drawbacks
Writing to closed HTTP::Server::Response raises
Closed stream (IO::Error)