Add DisableSameLayerUnpack option to cri config #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok this merged kevpar/containerd#33. Need to vendor in our fork here and then we can get this in |
This change adds a new option named DisableSameLayerUnpack that stops Containerd from being able to unpack the same layer in parallel. This is most common if a pull of the same image is performed at the same time or different images that share layers being pulled at the same time. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
helsaawy
approved these changes
Mar 17, 2022
anmaxvl
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new option named DisableSameLayerUnpack that stops Containerd from being able to unpack the same layer in parallel. This is most common if a pull of the same image is performed at the same time or different images that share layers being pulled at the same time.
This change relies on kevpar/containerd#33 landing to make use of the containerd.WithDisableSameLayerUnpack() option so I've left it as a draft for now to avoid an accidental merge but this is free to review.