epic: next generation compiler 🤔 #13553
Draft
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(developer): establish ng-compiler 🤔
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
…ompiler chore: merge master into ng-compiler 🤔
8 tasks
|
|
||
| # Next Generation Compiler | ||
|
|
||
| src/ng-compiler holds the fully typescript-based rewrite of the Kmn compiler currently in development. |
There was a problem hiding this comment.
Suggested change
| src/ng-compiler holds the fully typescript-based rewrite of the Kmn compiler currently in development. | |
| src/ng-compiler holds the fully typescript-based rewrite of the .kmn compiler currently in development. |
... otherwise, LGTM
markcsinclair
previously approved these changes
Apr 24, 2025
|
Hmm ... not sure if I should have approved this in draft, but I thought it was ready to go. |
Unless you are saying you've finished the ng-compiler epic, this should not yet be approved. This is long-lived branch that hosts the whole ng-compiler project, keeping it out of the alpha build until it is ready for merge. (And generally, yeah, don't approve a draft PR) |
…ompiler chore: merge master into ng-compiler 🤔
…ompiler chore: merge master into ng-compiler 🤔
mcdurdin
added a commit
to keymanapp/help.keyman.com
that referenced
this pull request
May 20, 2025
Relates to: * keymanapp/keyman#13553
…ompiler chore: merge master into ng-compiler 🤔
…ompiler chore: merge master into ng-compiler 🤔
…ompiler chore: merge master into ng-compiler 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec issue:
@keymanapp-test-bot skip