refactor(web): move RuleBehavior to engine/keyboard 🎼
#13997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
RuleBehavior to engine/keyboardRuleBehavior to engine/keyboard 🎼
mcdurdin
approved these changes
May 20, 2025
| export type Alternate = LexicalModelTypes.ProbabilityMass<LexicalModelTypes.Transform>; | ||
|
|
||
| export class TextTransform implements LexicalModelTypes.Transform { | ||
| readonly insert: string; |
| /* | ||
| * Keyman is copyright (C) SIL Global. MIT License. | ||
| * | ||
| * Defines deadkey management in a manner attachable to each element interface. |
|
|
||
| private static tokenSeed: number = 0; | ||
|
|
||
| constructor(keystroke: KeyEvent, transform: TextTransform, preInput: OutputTargetInterface, alternates?: Alternate[] /*, removedDks: Deadkey[], insertedDks: Deadkey[]*/) { |
There was a problem hiding this comment.
Need consistency in filename ending with systemStores.ts.
d895a33 to
dca5edb
Compare
This requires to move some other files around. Also move `finalize` and `mergeInDefaults` methods to processor and rename them to `finalizeProcessorAction` and `mergeInOtherProcessorAction` (decided 8000 to directly use the term `ProcessorAction`, to which `RuleBehavior` will be renamed to in a following PR). Co-authored-by: Marc Durdin <marc@durdin.net>
3018692 to
657585e
Compare
dca5edb to
1b14f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires to move some other files around. Also move
finalizeandmergeInDefaultsmethods to processor.Test-bot: skip