maint(web): improve TC build script for Keyman Web/Test 🔗 #14051
Conversation
This refactors the build script and makes some changes so that it is possible to run in a docker container on a developer's machine. Part-of: #13399 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
When building playwright complained about missing dependencies, so this change adds them.
…3399_tc-config_refactor
Co-authored-by: Marc Durdin <marc@durdin.net>
There was a problem hiding this comment.
See discussion in #14059 (comment) as well on installing deps in a build agent automatically
| builder_run_action test web_test_action | ||
| builder_run_action test check_build_size_action |
There was a problem hiding this comment.
Shouldn't check_build_size_action be just check_build_size and a part of web_test_action?
There was a problem hiding this comment.
That would make sense. However, web_test_action is also used from keyman-web-release.sh and there we don't check the size. So we could
a) change the release build to also check the size
b) have two versions of web_test_action, one with and the other without checking the size
c) integrate check_build_size_action into web_test_action but make it run depending on a parameter we pass
d) leave it as is and continue to call check_build_size_action separately.
There was a problem hiding this comment.
Gotcha, let's leave it with option (d) for now; it will be a little confusing in the logs to see test run twice but we can manage.
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash | |||
| #!/usr/bin/env bash | |||
| # Copyright (C) 2025 SIL International. All rights reserved. | |||
There was a problem hiding this comment.
We should be usin the standard header in all our scripts
There was a problem hiding this comment.
done in parent #14049
8000
resources/teamcity/web/keyman-web-test.sh
Outdated
| #!/usr/bin/env bash | ||
| # Copyright (C) 2025 SIL International | ||
| # Distributed under the MIT License. See LICENSE.md file in the project | ||
| # root for full license information. | ||
| # |
There was a problem hiding this comment.
done in parent #14049
|
Changes in this pull request will be available for download in Keyman version 19.0.59-alpha |
This refactors the build script and makes some changes so that it is possible to run in a docker container on a developer's machine.
Part-of: #13399
Test-bot: skip