maint(developer): move TC configuration for Keyman Developer to scripts 🔗 #14052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the existing TC configuration as closely as possible. Part-of: #13399 Test-bot: skip
5dfa5d2 to
797af43
Compare
ermshiperete
commented
May 26, 2025
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
approved these changes
May 28, 2025
| } | ||
|
|
||
| function publish_action() { | ||
| _publish_sentry |
There was a problem hiding this comment.
Can we test for Windows here and fail the script if not Windows
There was a problem hiding this comment.
I'll do that in #14059.
There was a problem hiding this comment.
I think we should make sure that the platform-specific build scripts are not run on the wrong platform -- with is_mac tests etc. For all three scripts.
There was a problem hiding this comment.
Makes sense. I'll do that in #14059.
…int/web/13399_tc-config_dev
4a9972c to
1904470
Compare
|
Changes in this pull request will be available for download in Keyman version 19.0.59-alpha |
This was referenced Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the existing TC configuration as closely as possible.
Part-of: #13399
Test-bot: skip