8000 refactor(web): rename `RuleBehavior` → `ProcessorAction` 🎼 by ermshiperete · Pull Request #14001 · keymanapp/keyman · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(web): rename RuleBehavior → ProcessorAction 🎼 #14001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

refactor(web): rename RuleBehavior → ProcessorAction 🎼 #14001

merged 2 commits into from
Jun 6, 2025

Conversation

ermshiperete
Copy link
Contributor

Test-bot: skip

@github-project-automation github-project-automation bot moved this to Todo in Keyman May 20, 2025
@keymanapp-test-bot
Copy link
keymanapp-test-bot bot commented May 20, 2025 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot changed the title refactor(web): rename RuleBehavior → ProcessorAction refactor(web): rename RuleBehavior → ProcessorAction 🎼 May 20, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S3 milestone May 20, 2025
jahorton
jahorton reviewed May 21, 2025
View reviewed changes
Copy link
Contributor
@jahorton jahorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also be sure to update references in the web/docs/internal section.

The following three files have references to the type:

  • context-state-management.md
  • keystroke-lifecycle.md
  • keystroke-processing.md

@ermshiperete ermshiperete force-pushed the refactor/web/variablestoredic branch from 454f946 to 7a18039 Compare May 21, 2025 07:56
@ermshiperete ermshiperete force-pushed the refactor/web/processoraction branch 2 times, most recently from 05c0e40 to 90d1d9a Compare May 21, 2025 08:14
@keyman-server keyman-server modified the milestones: A19S3, A19S4 May 26, 2025
@ermshiperete ermshiperete force-pushed the refactor/web/variablestoredic branch from 7a18039 to ff28ebc Compare June 5, 2025 15:40
@ermshiperete ermshiperete force-pushed the refactor/web/processoraction branch from 90d1d9a to d0112ea Compare June 5, 2025 15:41
@ermshiperete ermshiperete marked this pull request as ready for review June 5, 2025 15:42
@ermshiperete ermshiperete requested review from srl295 and mcdurdin June 5, 2025 15:42
Base automatically changed from refactor/web/variablestoredic to epic/web-core June 6, 2025 10:26
@ermshiperete ermshiperete merged commit 24041e8 into epic/web-core Jun 6, 2025
4 checks passed
@ermshiperete ermshiperete deleted the refactor/web/processoraction branch June 6, 2025 10:26
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Jun 6, 2025
@mcdurdin
Copy link
Member
mcdurdin commented Jun 9, 2025

Note: builds did not run on this PR due to #14146.

@mcdurdin mcdurdin mentioned this pull request Jun 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahorton jahorton jahorton left review comments

@mcdurdin mcdurdin mcdurdin approved these changes

@srl295 srl295 Awaiting requested review from srl295

Assignees
No one assigned
Labels
epic-web-core refactor web/
Projects
Keyman
Status: Done
Milestone
A19S4
Development

Successfully merging this pull request may close these issues.
4 participants
@ermshiperete @mcdurdin @jahorton @keyman-server
0