fix(windows): add values wucUpdateAvailable and wucNotChecked to TRemoteUpdateCheckResult enum #14123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TRemoteUpdateCheckResult now has wucUpdateAvailable and wucNotChecked to avoid confusion
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
…nloaded-after-3' into fix/windows/add-wuc-enum-result
ermshiperete
approved these changes
Jun 12, 2025
| @@ -723,7 +722,7 @@ procedure UpdateAvailableState.HandleCheck; | |||
| finally | |||
| CheckForUpdates.Free; | |||
| end; | |||
| if Result <> wucSuccess then | |||
| if Result <> wucFailure then | |||
There was a problem hiding this comment.
This doesn't seem right. I would expect something like
Suggested change
| if Result <> wucFailure then | |
| if Result = wucFailure then |
| // TODO: #14126 first check if already downloaded files are the same as the the latest files in | ||
| // the metadata, if not then we should download the new files. | ||
| if (Result = wucSuccess) and (TUpdateCheckStorage.CheckMetaDataForUpdate) then | ||
| // TODO: This actually needs to check if the updates available are newer then the already downloaded updates |
There was a problem hiding this comment.
Suggested change
| // TODO: This actually needs to check if the updates available are newer then the already downloaded updates | |
| // TODO: This actually needs to check if the updates available are newer than the already downloaded updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRemoteUpdateCheckResult now has wucUpdateAvailable and wucNotChecked to avoid confusion.
In terms of functionality it is no different then change made in #14095 this just moves the logic test
keyman/windows/src/desktop/kmshell/main/Keyman.System.UpdateStateMachine.pas
Line 644 in 4462be9
The tests will be covered in #14095
Test-bot: skip