8000 Unify fundamental terms throughout the application by mabartos · Pull Request #11304 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Unify fundamental terms throughout the application #11304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2022
Merged

Unify fundamental terms throughout the application #11304

merged 1 commit into from
Apr 29, 2022

Conversation

mabartos
Copy link
Contributor
@mabartos mabartos commented Apr 14, 2022 •
edited
Loading

Fixes #11301

@andymunro @tyandor Could you please take a look at this? Thank you.

@tyandor
Copy link
Contributor
tyandor commented Apr 14, 2022

Thanks for the heads up @mabartos! Changes we made here were requested by UX but if that creates inconsistency definitely not a problem to change back.

tyandor
tyandor approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor
@tyandor tyandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@andymunro
Copy link
Contributor

Generally our documentation always use log in rather than sign in. I think it is a good topic to suggest for the whole documentation set, but not for one PR.

@mabartos
Copy link
Contributor Author

@andymunro I'm not sure about this. In PR #10748, there were some changes related to those terms and I don't see any benefit by changing it there, rather the opposite. The account console was using the Sign in term before those changes[1] and it was consistent with the login screens. The documentation is more separated than the login and account screens together. I think this PR is relevant.

[1] https://github.com/keycloak/keycloak/pull/10748/files#diff-c9960d63791e169b1bd22eaa9d37a256f2e76c3738a9aa35365f1f62e9ec0ccaL98-L104

@andymunro
Copy link
Contributor

Thanks @mabartos. Okay, I see either way, there is some inconsistency with the UI or the documentation. If so, I agree with your suggested changes.

@ahus1 ahus1 added area/account/ui kind/bug Categorizes a PR related to a bug labels Apr 20, 2022
@abstractj abstractj requested a review from ssilvert April 26, 2022 12:40
@abstractj
Copy link
Contributor

Adding @ssilvert here considering the impact in the UI

@abstractj abstractj merged commit d931156 into keycloak:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abstractj abstractj abstractj approved these changes

@jonkoops jonkoops jonkoops approved these changes

@tyandor tyandor tyandor approved these changes

@andymunro andymunro andymunro approved these changes

@ssilvert ssilvert Awaiting requested review from ssilvert

@agagancarczyk agagancarczyk Awaiting requested review from agagancarczyk

@edewit edewit Awaiting requested review from edewit

Assignees
No one assigned
Labels
area/account/ui kind/bug Categorizes a PR related to a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify fundamental terms throughout the application
6 participants
@mabartos @tyandor @andymunro @abstractj @jonkoops @ahus1
0