8000 Encoded special chars in utf-8 and improved some translations by jaime-pineiro-imatia · Pull Request #21446 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Encoded special chars in utf-8 and improved some translations #21446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Encoded special chars in utf-8 and improved some translations #21446

wants to merge 3 commits into from

Conversation

jaime-pineiro-imatia
Copy link
Contributor

No description provided.

@jaime-pineiro-imatia jaime-pineiro-imatia requested a review from a team as a code owner July 5, 2023 06:47
jonkoops
jonkoops requested changes Jul 5, 2023
View reviewed changes
Copy link
Contributor
@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than encoding the special characters, let's add a header to set the encoding to UTF-8 (see #20848). This also means that previously encoded special chars should be decoded.

@jaime-pineiro-imatia
Copy link
Contributor Author

I've changed encoded chars and added header, but i think it will not work until #20848 is fixed, right?

@jonkoops
Copy link
Contributor
jonkoops commented Jul 5, 2023

I've changed encoded chars and added header, but i think it will not work until #20848 is fixed, right?

This should work as expected, are you seeing a different result when running Keycloak with these changes? #20848 is intended to convert the rest of the properties over, so you can consider this as a part of delivering that.

@jaime-pineiro-imatia
Copy link
Contributor Author

I'm testing with latest bitnami's image (version 21.1.2) and special chars are not displayed properly
image

@jonkoops
Copy link
Contributor
jonkoops commented Jul 6, 2023

How are you adding the changes in this PR to that image? I'd be interested in how that is done.

@jaime-pineiro-imatia
Copy link
Contributor Author
jaime-pineiro-imatia commented Jul 6, 2023 •
edited
Loading

In docker-compose.yml like this:

keycloak:
    image: docker.io/bitnami/keycloak:latest
    environment:
      KEYCLOAK_DATABASE_HOST: *KEYCLOAK_DATABASE_HOST
      KEYCLOAK_DATABASE_NAME: *KEYCLOAK_DATABASE_NAME
      KEYCLOAK_DATABASE_USER: *KEYCLOAK_DATABASE_USERNAME
      KEYCLOAK_DATABASE_PASSWORD: *KEYCLOAK_DATABASE_PASSWORD
      KEYCLOAK_ADMIN_USER: *KEYCLOAK_USERNAME
      KEYCLOAK_ADMIN_PASSWORD: *KEYCLOAK_PASSWORD
      KEYCLOAK_EXTRA_ARGS_PREPENDED: "--spi-login-protocol-openid-connect-legacy-logout-redirect-uri=true"
      KEYCLOAK_EXTRA_ARGS: "--import-realm"
    container_name: XXX-keycloak
    ports:
      - "8082:8080"
    volumes:
      - ./keycloak/import:/opt/bitnami/keycloak/data/import
      - ./keycloak/themes:/opt/bitnami/keycloak/themes

Mounting the theme in a volume

@jonkoops
Copy link
Contributor

Hi @jaime-pineiro-imatia, sorry for the late update. We've recently landed some changes to properly support UTF-8 (see #21714 and #21755), so this PR will no longer be needed. Thanks again for your efforts!

@jonkoops jonkoops closed this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonkoops jonkoops jonkoops requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaime-pineiro-imatia @jonkoops
0