8000 Allow `false` to be set for `pkceMethod` option by jonkoops · Pull Request #28347 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow false to be set for pkceMethod option #28347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2024
Merged

Allow false to be set for pkceMethod option #28347

merged 1 commit into from
Apr 9, 2024

Conversation

jonkoops
Copy link
Contributor
@jonkoops jonkoops commented Apr 2, 2024

Closes #28335

@jonkoops jonkoops requested a review from a team as a code owner April 2, 2024 11:31
@jonkoops jonkoops enabled auto-merge (squash) April 2, 2024 11:31
@jonkoops jonkoops mentioned this pull request Apr 2, 2024
Closed
2 tasks
agagancarczyk
agagancarczyk previously approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor
@agagancarczyk agagancarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonkoops jonkoops force-pushed the allow-false-pkce-method branch from 4093eaa to 5dcb0eb Compare April 2, 2024 16:26
mstichweh
mstichweh reviewed Apr 5, 2024
View reviewed changes
@jonkoops jonkoops force-pushed the allow-false-pkce-method branch from 5dcb0eb to dc00214 Compare April 9, 2024 07:17
@jonkoops
Allow false to be set for pkceMethod option
784cbbf 
Closes keycloak#28335

Signed-off-by: Jon Koops <jonkoops@gmail.com>
@jonkoops jonkoops force-pushed the allow-false-pkce-method branch from dc00214 to 784cbbf Compare April 9, 2024 07:17
@jonkoops jonkoops merged commit 9651af4 into keycloak:main Apr 9, 2024
@jonkoops jonkoops deleted the allow-false-pkce-method branch April 9, 2024 08:44
stianst pushed a commit to stianst/keycloak that referenced this pull request Apr 16, 2024
@jonkoops
Allow false to be set for pkceMethod option (keycloak#28347) (#152)
3ea3b26 
Closes keycloak#28335

Signed-off-by: Jon Koops <jonkoops@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstichweh mstichweh mstichweh left review comments

@edewit edewit edewit approved these changes

@agagancarczyk agagancarczyk agagancarczyk left review comments

Assignees
No one assigned
Labels
team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The false option of the pkceMethod init parameter for the JavaScript adapter is ignored
4 participants
@jonkoops @edewit @agagancarczyk @mstichweh
0