Fix numbering of recovery codes when downloading or copying them #34011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
ahus1
approved these changes
Oct 17, 2024
Closes keycloak#33933 Signed-off-by: NoseSnatcher <nosesnatcher@ffrwnd.me>
auto-merge was automatically disabled
October 17, 2024 16:06
Head branch was pushed to by a user without write access
|
@NoseSnatcher - please don't rebase your PR unless you've been asked to do so by a maintainer or a conflict occurs. It would otherwise reset previous approvals, and would require all CI to run again. |
|
@ahus1 Sorry, it's my first time doing this. I thought I had to either merge or rebase, since my fork is behind upstream by now. |
|
No worries. The GitHub UI is kinda confusing, and seems to imply a rebase is required to get your PR merged. This is common issue that is reported on the support forum, but it seems they are unaware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33933